switchon@lavalamp.biz
+27(0) 83 419 4851 / +27(0) 21 036 1165
Application & software development
Get A Quote

    • Home
    • Services
      • Application & software development
      • Outsourced software development
      • Project based resourcing
      • Digital marketing & consulting
      • Graphic design & consulting
      • UI / UX design & consulting
      • Recruitment services
      • Lease an expert
    • About
      • How we work
      • NBConsult Group
      • Partners
      • Lightbox Digital
    • Blog
    • Join us
    • Contact

    • Home
    • Services
      • Application & software development
      • Outsourced software development
      • Project based resourcing
      • Digital marketing & consulting
      • Graphic design & consulting
      • UI / UX design & consulting
      • Recruitment services
      • Lease an expert
    • About
      • How we work
      • NBConsult Group
      • Partners
      • Lightbox Digital
    • Blog
    • Join us
    • Contact

    • Home
    • Services
      • Application & software development
      • Outsourced software development
      • Project based resourcing
      • Digital marketing & consulting
      • Graphic design & consulting
      • UI / UX design & consulting
      • Recruitment services
      • Lease an expert
    • About
      • How we work
      • NBConsult Group
      • Partners
      • Lightbox Digital
    • Blog
    • Join us
    • Contact

    • Home
    • Services
      • Application & software development
      • Outsourced software development
      • Project based resourcing
      • Digital marketing & consulting
      • Graphic design & consulting
      • UI / UX design & consulting
      • Recruitment services
      • Lease an expert
    • About
      • How we work
      • NBConsult Group
      • Partners
      • Lightbox Digital
    • Blog
    • Join us
    • Contact
    why having a website is important
    Why Having A Website Is Important
    Feb 20, 2023
    migration scripts
    Migration Scripts
    Mar 22, 2023

    Improved Code Review

    improved code review
    improved code review

    Code reviews are a daily occurrence for software developers. It can be a crushing learning experience, but it can also turn into a selfish process. Here are a few tips to help you become a more successful and decisive reviewer.



    Structuring pull requests to make life easier


    Avoid huge changelogs

    • Keep the change log as small as possible.
    • If your changelog is longer than 600 lines, try breaking it down into smaller clear parts that can be reviewed separately.
    • Nobody wants to receive a 1000+ line pull request monster. Good reviewers often reject pull requests of this size as they know from experience that they likely won't be able to review it adequately.

    Structure to understand

    • Bunch similar changes into commits. Did you change the location of multiple files without altering them? Group these changes into the same commit so that the reviewer knows they are not logical changes they must focus on.
    • Commit your changes frequently to reduce its scope. It is much easier for reviewers to focus on what's important when commits are small than when dealing with larger commits.

    Stop possible confusion

    If you change the logic or structure that existed in preceding commits, you should inform reviewers so that they are not distracted by criticizing code that does not exist anymore. This applies when reviewers go through commits one by one.


    Provide sufficient context

    Make sure the pull request is clearly explained, either through a linked ticket or through a written explanation in the pull request, or preferably both. Provide visual or other examples of how your work affects the project. Try to see things from the reviewer's point of view and make it as easy as possible to understand the purpose of the pull request.


    Effective access to team member's PR


    Timely review

    • Try to review a pull request as soon as you are added as a reviewer.
    • The maximum time from a pull request to completion of first review must not exceed 1 business day.

    Gather context if missing

    If a pull request is missing context or a description of all changes, contact the author for clarification before reviewing. This can greatly reduce discussions due to misinterpretations of the code or its purpose.


    Start at high level

    Review from the high level down. Don’t comment on small changes like styling until any large issues are dealt with. This allows authors to focus on the most important fixes first. Sometimes small problems go away along with the bigger changes.


    Disagreement handling

    If you disagree with the code block, provide a code example of how you suggest it should be done. It is much more helpful to other developers than leaving a "this should be different" comment.


    Change request

    Do not block pull requests unless there are fundamental problems. Putting an obstacle in front of your colleague over an argument around naming does not help anyone on the team. Give your team the opportunity to review small changes and continue working without waiting for the next piece of feedback.


    Empathy

    Most importantly, remember there is another person at the other side of the review. Provide feedback in a useful and constructive manner. Always think about how you would like to receive feedback if it was pull request being reviewed.

    Contact us


      Related posts:

      laravel livewireLaravel Livewire rules for ux designersRules For UX Designers 9 tips to prevent programmer burnout9 Tips To Prevent Programmer Burnout vs code with code snippetsMaking The Most Of VS Code With Code Snippets
      Share
      0
      Jacques Le Roux
      Jacques Le Roux

      Leave a Reply Cancel reply

      Your email address will not be published. Required fields are marked *

      Lava Lamp Lab


      Like technology, a lava lamp constantly changes form, producing new conditions with every passing moment



      lava lamp lab facebook   lava lamp lab twitter   lava lamp lab linkedin   lava lamp lab instgram

      Services


      Application & software development

      Outsourced software development

      Project based resourcing

      Digital marketing & consulting

      Graphic design & consulting

      UI / UX design & consulting

      Contact Us


      +27(0) 83 419 4851

      +27(0) 21 036 1165


      switchon@lavalamp.biz


      Unit 1 Monaco Square,
      14 Church Street,
      Durbanville,
      Cape Town, 7550

      NBConsult Group


      nbconsult
      nbconnect msp
      nbclearning
      river broadband
      designer needed
      © 2023 Lava Lamp Lab (Pty) Ltd | All Rights Reserved | Privacy Policy
      Contact us now

        Application & software development

          Outsourced software development

            Project based resourcing

              Digital marketing & consulting

                Graphic design & consulting

                  UI/UX design & consulting

                    Lease an expert

                      Recruitment services

                        We are using cookies to give you the best experience on our website.

                        You can find out more about which cookies we are using or switch them off in settings.

                        Lava Lamp Lab
                        Powered by  GDPR Cookie Compliance
                        Privacy Overview

                        This website uses cookies so that we can provide you with the best user experience possible. Cookie information is stored in your browser and performs functions such as recognising you when you return to our website and helping our team to understand which sections of the website you find most interesting and useful.

                        Strictly Necessary Cookies

                        Strictly Necessary Cookie should be enabled at all times so that we can save your preferences for cookie settings.

                        If you disable this cookie, we will not be able to save your preferences. This means that every time you visit this website you will need to enable or disable cookies again.

                        3rd Party Cookies

                        This website uses Google Analytics to collect anonymous information such as the number of visitors to the site, and the most popular pages.

                        Keeping this cookie enabled helps us to improve our website.

                        Please enable Strictly Necessary Cookies first so that we can save your preferences!

                        Cookie Policy

                        More information about our Cookie Policy